Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged configure facility and configure health facility in one page #6171

Merged
merged 6 commits into from
Aug 30, 2023

Conversation

kshitijv256
Copy link
Contributor

@kshitijv256 kshitijv256 commented Aug 28, 2023

WHAT

🤖 Generated by Copilot at e9d94be

Refactored the facility configuration flow to integrate the ABDM feature settings and avoid nested Page components. Removed unused ConfigureHealthFacility route and component from AppRouter and FacilityHome. Simplified the rendering of ConfigureHealthFacility and UpdateFacilityMiddleware components.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@kshitijv256 kshitijv256 requested a review from a team August 28, 2023 13:54
@kshitijv256 kshitijv256 requested a review from a team as a code owner August 28, 2023 13:54
@vercel
Copy link

vercel bot commented Aug 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 2:00pm

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 916cfdd
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64edf9ca169c30000721e420
😎 Deploy Preview https://deploy-preview-6171--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comments, otherwise the pr looks good

src/Components/ABDM/ConfigureHealthFacility.tsx Outdated Show resolved Hide resolved
@khavinshankar khavinshankar added reviewed reviewed by a core member needs testing labels Aug 29, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 55240e5 into ohcnetwork:develop Aug 30, 2023
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed reviewed by a core member tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge "Configure Facility" and "Configure Health Facility" to one page: "Configure Facility"
3 participants