Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI Fix: Button background should not appear when loading #6172

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Aug 29, 2023

WHAT

🤖 Generated by Copilot at e7b992a

Improved the UI of the skills slide over component by adding a circular progress indicator for skill addition requests. Modified src/Components/Users/SkillsSlideOver.tsx to implement this feature.

Proposed Changes

https://care.coronasafe.in/users
The Loader on the Add Skills to a User doesn't look good.
Removed the green background behind the loader

Steps:

  1. Open the URL
  2. Click on Linked Skills of any user
  3. Try to add a skill that has already been added
  4. See the loader

Before:
image

Now:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at e7b992a

  • Show a circular progress indicator instead of the "Add" button when adding a skill (link)

@Pranshu1902 Pranshu1902 requested a review from a team August 29, 2023 08:38
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 29, 2023 08:38
@vercel
Copy link

vercel bot commented Aug 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 8:39am

@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e7b992a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64edae7ec03cdd000836baf1
😎 Deploy Preview https://deploy-preview-6172--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a16fbfd into coronasafe:develop Aug 30, 2023
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants