Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Prescriptions table when No Medicines prescribed #6200

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Improve Prescriptions table when No Medicines prescribed #6200

merged 1 commit into from
Sep 1, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 1, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at a6b9ebf

Fix UI and logic bugs in PrescriptionAdministrationsTable component. Improve user experience and error handling for medicine administration data.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at a6b9ebf

  • Disable export button when prescriptions are empty or undefined (link)
  • Move empty state message outside of table element and make it fill full width (link)
  • Add optional chaining operator to prevent error when accessing created_date property of prescriptions array (link)

@rithviknishad rithviknishad requested a review from a team September 1, 2023 05:58
@rithviknishad rithviknishad requested a review from a team as a code owner September 1, 2023 05:58
@vercel
Copy link

vercel bot commented Sep 1, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 5:58am

@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a6b9ebf
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f17d822070bf0008237066
😎 Deploy Preview https://deploy-preview-6200--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Sep 1, 2023
@nihal467
Copy link
Member

nihal467 commented Sep 1, 2023

LGTM

@khavinshankar khavinshankar merged commit 1457267 into develop Sep 1, 2023
33 of 34 checks passed
@khavinshankar khavinshankar deleted the no-medicines branch September 1, 2023 06:44
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure tested
Projects
None yet
Milestone
No milestone
3 participants
@rithviknishad @nihal467 @khavinshankar