Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the loader display on Patient Notes page #6204

Merged
merged 3 commits into from
Sep 21, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Sep 1, 2023

WHAT

🤖 Generated by Copilot at 938fc35

This pull request enhances the PatientNotes component by improving its performance, usability, and appearance. It reduces unnecessary loading indicators, allows users to type and edit notes, and displays the notes list only when the data is ready.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 938fc35

  • Move the loading component to a conditional rendering inside the PatientNotes component, so that it only shows when the notes data is being fetched from the API (link, link)
  • Add the value prop to the InputField component, which is used to enter a new note for a patient, and set it to the noteField state variable, which stores the current input value of the note (link)

@Pranshu1902 Pranshu1902 requested a review from a team September 1, 2023 08:56
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner September 1, 2023 08:56
@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 21, 2023 2:07pm

@netlify
Copy link

netlify bot commented Sep 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 08722e2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/650c4de4f55d1c0008fdf110
😎 Deploy Preview https://deploy-preview-6204--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Pranshu1902 Pranshu1902 changed the title fix loader Fix the loader display on Patient Notes page Sep 1, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit c0f0e4b into coronasafe:develop Sep 21, 2023
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Notes page completely loads on adding a new note
3 participants