-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added UI enhancements to the preview page #6221
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- There are two shadows!
- The buttons make sense to be placed center bottom maybe?
@yogeshbhutkar consider using the |
dd1b719
to
72c5164
Compare
@yogeshbhutkar is this ready for review? Just curious to know, was there a reason why you haven't reused the existing slideover component? |
Also, you'll have to untrack ur package-lock.json changes as you are not changing any dependencies voluntarily |
…re_fe into featureBranch-1 Updating the featureBranch with the origin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything else LGTM! Nice work!
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
Closed in favour of #6296 |
WHAT
🤖 Generated by Copilot at dd1b719
This file enhances the file preview dialog component by using a custom button, a smoother transition, and a better close button. These changes improve the user interface and experience of viewing files in the app.
Proposed Changes
An image of the new tested solution.
![image](https://private-user-images.githubusercontent.com/73941119/265505934-c85b4d9f-d648-4817-bc93-02e1b2fb9d9f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjYxNDcwMjksIm5iZiI6MTcyNjE0NjcyOSwicGF0aCI6Ii83Mzk0MTExOS8yNjU1MDU5MzQtYzg1YjRkOWYtZDY0OC00ODE3LWJjOTMtMDJlMWIyZmI5ZDlmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTEyVDEzMTIwOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5ZTJmMmQ5ODlkYTlkNWY4ZTg2ODQzMDczODNkYmQwYmQ4YTEwYzAzNzYyMzJkODVmZTAzY2E3MTkyOGEwYmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.YBFnuVFpfYt6wtG-IyRmNsPf98msEHnJTwYOeD1pYqw)
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at dd1b719
button
elements with customButtonV2
component in file preview dialog (link, link, link)