Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live Camera Feed Enhancement(Review, QA and testing) #6223

Open
wants to merge 193 commits into
base: develop
Choose a base branch
from

Conversation

JahnabDutta
Copy link
Contributor

@JahnabDutta JahnabDutta commented Sep 5, 2023

WHAT

🤖 Generated by Copilot at da93272

This pull request adds new features and improvements to the camera feed and the notification system in the frontend application. It enables users to add, update, delete, and preview camera boundary presets for beds, as well as toggle patient privacy mode for the camera feed. It also refactors the notification subscription logic into a custom hook and adds end-to-end tests for the camera features. It modifies several components, hooks, models, constants, actions, and routes to implement these features and improvements. It also fixes some minor issues with the code formatting and style.

Proposed Changes

  • Testing and QA related PR for Live Camera Feed Enhacnement feature.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at da93272

  • Add and implement custom hook useNotificationSubscribe for managing notification subscription state and actions (F4, link, link, link, link, link, link)
  • Add and implement custom hook useFeedPTZ for managing camera feed and asset operations (link, link, link, link)
  • Add and implement PatientPrivacyToggle component for rendering and toggling privacy mode for camera feed (F13, link, link, link, link, link)
  • Add and implement CameraBoundaryConfigure and UpdateCameraBoundaryConfigure components for rendering and performing boundary preset actions for camera feed (F6, link, link, link, link, link, link, link, link)
  • Modify CameraConfigure component for rendering and performing preset actions for camera feed (F7, link)
  • Modify ONVIFCamera component for rendering and passing props to LiveFeed component (link, link)
  • Modify SwitchTabs component to accept custom class name prop (link, link)
  • Modify FileUpload component to improve voice recorder layout (link)
  • Modify ConsultationDetails component to wrap camera feed tab content in Page component (link, link)
  • Modify BedModel and CurrentBed interfaces to add meta and privacy properties (link, link)
  • Add direction and BoundaryRange types to src/Common/constants.tsx (link)
  • Add end-to-end tests for camera boundary and patient privacy features (link, link)
  • Add space character to if statement in src/index.tsx (link)

JahnabDutta and others added 30 commits May 26, 2023 13:07
Signed-off-by: JahnabDutta <dutta.4@iitj.ac.in>
Signed-off-by: JahnabDutta <dutta.4@iitj.ac.in>
@Pranshu1902 Pranshu1902 removed the merge conflict pull requests with merge conflict label Mar 7, 2024
@nihal467
Copy link
Member

nihal467 commented Mar 11, 2024

@Pranshu1902

  • Attach a full QA video of the PR
  • attach the screenshot of passing the cypress test
  • fix the backend test

Copy link

👋 Hi, @JahnabDutta,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 19, 2024
@gigincg
Copy link
Member

gigincg commented Aug 5, 2024

@khavinshankar Can you go through the PR, find out if it's usable or not? And update here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

[C4GT] Live Camera Feed Enhancement
6 participants