Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open pdf file preview in new tab #6226

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Open pdf file preview in new tab #6226

merged 1 commit into from
Sep 6, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 5, 2023

WHAT

🤖 Generated by Copilot at 00bf8aa

Enhance file upload component for patient files. Add pdf viewer, fix voice recorder layout, and enable file access and download in FileUpload.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 00bf8aa

  • Add conditional logic to open pdf files in a new tab instead of a modal (link)
  • Swap the order of flex-direction classes for the voice recorder and upload button div (link)

@Ashesh3 Ashesh3 requested a review from a team September 5, 2023 13:23
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 5, 2023 13:23
@Ashesh3 Ashesh3 requested a review from bodhish September 5, 2023 13:23
@vercel
Copy link

vercel bot commented Sep 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2023 1:23pm

@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 00bf8aa
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f72bc1f8dc5e0007129568
😎 Deploy Preview https://deploy-preview-6226--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added cypress failed pull request with cypress test failure cypress passed and removed cypress failed pull request with cypress test failure labels Sep 5, 2023
@nihal467
Copy link
Member

nihal467 commented Sep 6, 2023

LGTM

@khavinshankar khavinshankar merged commit b94851c into develop Sep 6, 2023
36 checks passed
@khavinshankar khavinshankar deleted the issue-6155 branch September 6, 2023 13:57
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

ShivamJhaa pushed a commit to ShivamJhaa/care_fe that referenced this pull request Sep 6, 2023
khavinshankar pushed a commit that referenced this pull request Sep 7, 2023
…6106)

* lints

* Added test for resource and migrated it to POM

* trying a fix

* nits

* backend change

* Reverted useless changes

* fix test

* Fixed failing test

* Added api verification

* Diagnosis: Adds field Principal Diagnosis (#6218)

* adds field principle diagnosis

* show in consultation details

* fix typo

* fix cypress

* try adding wait

* fix tests

* open pdf file preview in new tab (#6226)

* Changed weekly to average weekly for working hours (#6228)

* Added padding to count block on patients page

* fixed date format in asset manage page

* Merged configure facility and configure health facility in one page

* removed commented code

* changed weekly to average weekly for working hours

* Resolved comments

---------

Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com>
Co-authored-by: Rithvik Nishad <mail@rithviknishad.dev>
Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com>
Co-authored-by: Kshitij Verma <101321276+kshitijv256@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discharge summary preview is having multiple download button
3 participants