Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the form consistent #6238

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Sep 7, 2023

WHAT

🤖 Generated by Copilot at b81dd1e

Fixed the alignment of buttons in the AddLocationForm component. This improves the UI consistency and layout of the form in the facility module.

Proposed Changes

https://care.coronasafe.in/facility/caaab916-e877-4153-a0a4-d0afc69f4c1a/location/add
Move the cancel button to the right to be consistent with the site.

Before:
image

After:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at b81dd1e

  • Align cancel and save buttons to the right end of the form in AddLocationForm.tsx (link)

@Pranshu1902 Pranshu1902 requested a review from a team September 7, 2023 10:10
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner September 7, 2023 10:10
@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 10:16am

@netlify
Copy link

netlify bot commented Sep 7, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit aa254d0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64f9a2f435e6fa0007a3b885
😎 Deploy Preview https://deploy-preview-6238--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@nihal467
Copy link
Member

LGTM

@khavinshankar
Copy link
Member

@rithviknishad can you re-review this once

@khavinshankar khavinshankar merged commit 4e8005c into coronasafe:develop Sep 11, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants