Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consultation Form: skip validation for verified_by if suggestion is Declare Death and fix discharge not working on create consultation #6248

Merged
merged 2 commits into from
Sep 8, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Sep 8, 2023

WHAT

🤖 Generated by Copilot at 89137e8

Fix verified_by validation for discharge decisions. The change allows the consultation form to be submitted without a verified_by value if the suggestion is DD, as requested in issue #1729.

Proposed Changes

  • Consultation Form: skip validation for verified_by if suggestion is Declare Death
  • Declare Death and fix discharge not working on create consultation #

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 89137e8

  • Add a condition to skip verified_by validation for discharge decisions (link)

@rithviknishad rithviknishad requested a review from a team September 8, 2023 14:35
@rithviknishad rithviknishad requested a review from a team as a code owner September 8, 2023 14:35
@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 8, 2023 3:18pm

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4a7d832
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64fb3b3303df960008183ea7
😎 Deploy Preview https://deploy-preview-6248--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Sep 8, 2023
@rithviknishad rithviknishad changed the title Consultation Form: skip validation for verified_by if suggestion is Declare Death Consultation Form: skip validation for verified_by if suggestion is Declare Death and fix discharge not working on create consultation Sep 8, 2023
@khavinshankar khavinshankar merged commit fb4e7be into develop Sep 8, 2023
33 checks passed
@khavinshankar khavinshankar deleted the fix-verifiedby-validation branch September 8, 2023 15:28
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress passed P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants