Show only those facilties that aren't linked to user #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Waiting for backend |
|
@Pranshu1902 fix your backend test and mark it for testing |
LGTM the functionality , @Pranshu1902 fix the failing cypress as well |
|
@nihal467 done! |
nihal467
approved these changes
Oct 25, 2023
|
@khavinshankar upon back-end merges, the cypress will pass through, |
|
👋 Hi, @Pranshu1902, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
The back-end PR is merged, this PR can be merged now |
khavinshankar
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at daa88cd
Added user-based facility filtering to
FacilitySelectcomponent. This enables managing user permissions for different facilities in theManageUserspage.http://localhost:4000/users
Only shows those facilities in the drop-down that are not linked to the user.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at daa88cd
usernameproperty toFacilitySelectPropsinterface to pass the username of the selected user to theFacilitySelectcomponent (link)usernameprop fromFacilitySelectPropsobject and pass it to theuseEffecthook as a dependency inFacilitySelect.tsx(link)usernamevalue in the query parameters of thelistFacilityAPI call to fetch the facilities assigned to the selected user inFacilitySelect.tsx(link)usernameprop to theFacilitySelectcomponent from theUserFacilitiescomponent to render the facility selection for each user in the manage users page inManageUsers.tsx(link)