Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed react-swipeable-views package #6312

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Removed react-swipeable-views package #6312

merged 3 commits into from
Sep 20, 2023

Conversation

thtauhid
Copy link
Contributor

@thtauhid thtauhid commented Sep 20, 2023 •
edited
Loading

WHAT

🤖 Generated by Copilot at a88a5cc

Improved tab navigation in ManagePatients component by using TabPanel and URL query parameters. This enhanced the component's speed and user experience.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at a88a5cc

  • Remove unused import of SwipeableViews from ManagePatients.tsx (link)
  • Replace SwipeableViews component with two TabPanel components for each tab in ManagePatients.tsx (link)

@thtauhid thtauhid requested a review from a team September 20, 2023 11:12
@thtauhid thtauhid requested a review from a team as a code owner September 20, 2023 11:12
@netlify
Copy link

netlify bot commented Sep 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1099554
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/650b07d62e606800083ae1f3
😎 Deploy Preview https://deploy-preview-6312--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Sep 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 2:55pm

rithviknishad
rithviknishad reviewed Sep 20, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thtauhid is this package being used elsewhere? if not it would be good to uninstall it too!

@thtauhid
Copy link
Contributor Author

@rithviknishad nope. I'll remove the package also.

@thtauhid thtauhid changed the title removed SwipeableViews from ManagePatients.tsx Removed react-swipeable-views package Sep 20, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 9fe59db into coronasafe:develop Sep 20, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
cypress passed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

patient tab page is malfunctioning in the mobile view
4 participants
@thtauhid @nihal467 @rithviknishad @khavinshankar