Refactor: replaced Dispatch to useQuery/Request of src/Components/Auth/log… #6333

jevil25 · 2023-09-22T16:54:44Z

Hello,

I wanted to verify whether what I have done is on the right track?

WHAT

replaced useDispatch with useQuery in (src/Components/Auth/login.tsx)

Proposed Changes

Fixes 🛠️ Replace useDispatch w. useQuery/request: Auth (src/Components/Auth/**) #6331

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

HOW

vercel · 2023-09-22T16:54:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
care-storybook	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 1, 2023 9:57am

netlify · 2023-09-22T16:54:49Z

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	`a1bd18b`
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/65194251eea2ce0008403da0
😎 Deploy Preview	https://deploy-preview-6333--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad

Hey @jevil25 have a look at the EPIC issue linked to the issue.

Refer the example PR and documentation on how and when to use request vs useQuery

src/Components/Auth/Login.tsx

jevil25 · 2023-09-23T13:18:59Z

Hello @rithviknishad ,
I hadn't understood properly the last time.
I have done all the proposed changes to login.tsx file, I also had to add reponse types in api.tsx file.
Is it right this time or do I need to do more changes?

rithviknishad

Mostly everything seems okay to me.
Just some minor suggestions

src/Redux/api.tsx

src/Components/Auth/Login.tsx

nihal467 · 2023-09-26T07:25:31Z

@jevil25 the whole cypress test is failing, check the failure

CC: @rithviknishad

jevil25 · 2023-09-26T14:21:57Z

Hey @nihal467,
I fixed the issues and ran the cypress tests locally it has passed can you test again and check once.
Thank you

CC: @rithviknishad

rithviknishad

You'll also have to add TBody type definitions for all mutation routes such as (POST PUT PATCH DELETE).

9bc19ed Adds support for it. so you'll have to rebase with the latest develop too in order to do that.

…in.tsx

jevil25 · 2023-09-28T14:15:21Z

hey @rithviknishad ,
I have done all the change asked, rebased it and added the TBody types to mutations.

src/Redux/api.tsx

package-lock.json

rithviknishad · 2023-10-01T09:24:08Z

Nice work @jevil25 , rest everything LGTM

nihal467 · 2023-10-03T01:23:15Z

LGTM

…h/log… (#6333) * Refactor: replaced useDispatch to useQuery of src/Components/Auth/login.tsx * fix:useQuery changed to Request * feat: replaced dispatch with request * fix: types and added pathparams * fix: request body error * Update Login.tsx * change:Tres to Tbody * fixes: response type change * Update package-lock.json

* Middleware override feature in asset location * Fix tooltip clipping * Fix Flaky Cypress test in Facility Module (#6384) * fix random facility page failure * fix random facility page failure * Revert "Prescriptions: Shrink discontinued prescriptions + Flip MAR timeline + Freeze primary columns in horizontal scroll (#6282)" (#6386) This reverts commit 5009a86. * Refactor Asset Model Import Formatting (#6388) * Refactor Asset Model Import Formatting * fixes to warranty_amc_end_of_validity * Fix asset import file for cypress * Refactor: replaced Dispatch to useQuery/Request of src/Components/Auth/log… (#6333) * Refactor: replaced useDispatch to useQuery of src/Components/Auth/login.tsx * fix:useQuery changed to Request * feat: replaced dispatch with request * fix: types and added pathparams * fix: request body error * Update Login.tsx * change:Tres to Tbody * fixes: response type change * Update package-lock.json * fix hover height (#6352) * Split routes of App Router (#6363) * Prescription: show prescribed on & by and discontinued date in detail card (#6365) * Fixed bug in location picker in update facility page (#6377) * add all cases for map rendering * implement location pointer on searched location * Added cam auto reset in asset config page (#6375) * 💊 Adds support for editing prescriptions + Adds `useSlug` hook (#6369) * Adds hook: `useSlug` * bug fix: NumericWithUnits field not showing intial value * Form: support for showing global errors * Adds support for editing prescriptions (fixes #6340) * Fix cypress * fix cypress * Improve design --------- Co-authored-by: Mohammed Nihal <57055998+nihal467@users.noreply.github.com> Co-authored-by: Rithvik Nishad <mail@rithviknishad.dev> Co-authored-by: Aaron Jevil Nazareth <93522968+jevil25@users.noreply.github.com> Co-authored-by: Pranshu Aggarwal <70687348+Pranshu1902@users.noreply.github.com> Co-authored-by: Gampa Sri Harsh <114745442+sriharsh05@users.noreply.github.com> Co-authored-by: Tasnimul H. Tauhid <thtauhid.71@gmail.com>

jevil25 requested a review from a team September 22, 2023 16:54

jevil25 requested a review from a team as a code owner September 22, 2023 16:54

jevil25 requested a review from gigincg September 22, 2023 16:54

vercel bot deployed to Preview September 22, 2023 16:55 View deployment

jevil25 marked this pull request as draft September 22, 2023 16:55

jevil25 mentioned this pull request Sep 22, 2023

🛠️ Replace useDispatch w. useQuery/request: Auth (src/Components/Auth/**) #6331

Closed

rithviknishad requested changes Sep 23, 2023

View reviewed changes

vercel bot deployed to Preview September 23, 2023 13:15 View deployment

jevil25 marked this pull request as ready for review September 23, 2023 13:16

jevil25 changed the title ~~Refactor: replaced useDispatch to useQuery of src/Components/Auth/log…~~ Refactor: replaced Dispatch to useQuery/Request of src/Components/Auth/log… Sep 23, 2023

rithviknishad requested changes Sep 23, 2023

View reviewed changes

src/Redux/api.tsx Outdated Show resolved Hide resolved

src/Components/Auth/Login.tsx Outdated Show resolved Hide resolved

vercel bot deployed to Preview September 24, 2023 06:03 View deployment

rithviknishad added the needs testing label Sep 25, 2023

vercel bot deployed to Preview September 26, 2023 06:41 View deployment

nihal467 added test failed and removed needs testing labels Sep 26, 2023

vercel bot deployed to Preview September 26, 2023 14:23 View deployment

rithviknishad added needs testing and removed test failed labels Sep 26, 2023

rithviknishad requested changes Sep 27, 2023

View reviewed changes

rithviknishad added changes required and removed needs testing labels Sep 27, 2023

jevil25 and others added 3 commits September 28, 2023 18:10

Refactor: replaced useDispatch to useQuery of src/Components/Auth/log…

4e4ea54

…in.tsx

fix:useQuery changed to Request

a0978e4

feat: replaced dispatch with request

e0516f3

jevil25 and others added 3 commits September 28, 2023 18:10

fix: types and added pathparams

e2ccb9a

fix: request body error

7f493ca

Update Login.tsx

bfd54df

jevil25 force-pushed the patch-1 branch from b0f0090 to bfd54df Compare September 28, 2023 12:40

vercel bot deployed to Preview September 28, 2023 12:41 View deployment

change:Tres to Tbody

4d14f2b

vercel bot deployed to Preview September 28, 2023 14:09 View deployment

jevil25 requested a review from rithviknishad October 1, 2023 09:17

rithviknishad reviewed Oct 1, 2023

View reviewed changes

src/Redux/api.tsx Outdated Show resolved Hide resolved

rithviknishad added needs testing and removed changes required labels Oct 1, 2023

rithviknishad reviewed Oct 1, 2023

View reviewed changes

package-lock.json Outdated Show resolved Hide resolved

fixes: response type change

73130b2

vercel bot deployed to Preview October 1, 2023 09:54 View deployment

Update package-lock.json

a1bd18b

vercel bot deployed to Preview October 1, 2023 09:57 View deployment

rithviknishad approved these changes Oct 1, 2023

View reviewed changes

nihal467 added the cypress passed label Oct 3, 2023

nihal467 added tested and removed needs testing labels Oct 3, 2023

khavinshankar approved these changes Oct 4, 2023

View reviewed changes

khavinshankar merged commit d53eed9 into coronasafe:develop Oct 4, 2023
32 of 33 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor: replaced Dispatch to useQuery/Request of src/Components/Auth/log… #6333

Refactor: replaced Dispatch to useQuery/Request of src/Components/Auth/log… #6333

jevil25 commented Sep 22, 2023 •

edited by rithviknishad

Loading

vercel bot commented Sep 22, 2023 •

edited

Loading

netlify bot commented Sep 22, 2023 •

edited

Loading

rithviknishad left a comment

jevil25 commented Sep 23, 2023 •

edited

Loading

rithviknishad left a comment •

edited

Loading

nihal467 commented Sep 26, 2023

jevil25 commented Sep 26, 2023

rithviknishad left a comment •

edited

Loading

jevil25 commented Sep 28, 2023

rithviknishad commented Oct 1, 2023

nihal467 commented Oct 3, 2023

Refactor: replaced Dispatch to useQuery/Request of src/Components/Auth/log… #6333

Refactor: replaced Dispatch to useQuery/Request of src/Components/Auth/log… #6333

Conversation

jevil25 commented Sep 22, 2023 • edited by rithviknishad Loading

I wanted to verify whether what I have done is on the right track?

WHAT

Proposed Changes

Merge Checklist

HOW

vercel bot commented Sep 22, 2023 • edited Loading

netlify bot commented Sep 22, 2023 • edited Loading

✅ Deploy Preview for care-egov-staging ready!

rithviknishad left a comment

Choose a reason for hiding this comment

jevil25 commented Sep 23, 2023 • edited Loading

rithviknishad left a comment • edited Loading

Choose a reason for hiding this comment

nihal467 commented Sep 26, 2023

jevil25 commented Sep 26, 2023

rithviknishad left a comment • edited Loading

Choose a reason for hiding this comment

jevil25 commented Sep 28, 2023

rithviknishad commented Oct 1, 2023

nihal467 commented Oct 3, 2023

jevil25 commented Sep 22, 2023 •

edited by rithviknishad

Loading

vercel bot commented Sep 22, 2023 •

edited

Loading

netlify bot commented Sep 22, 2023 •

edited

Loading

jevil25 commented Sep 23, 2023 •

edited

Loading

rithviknishad left a comment •

edited

Loading

rithviknishad left a comment •

edited

Loading