Remove default selection of patient category #6354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #1318 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
@Ashesh3 fix the cypress |
|
LGTM |
khavinshankar
approved these changes
Sep 27, 2023
|
@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at a336f5f
The pull request makes the
categoryandpatient_categoryfields mandatory in the consultation and daily rounds forms, respectively, to ensure accurate and consistent data entry. It also fixes a bug in the default value ofpatient_categoryin theDailyRoundscomponent.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at a336f5f
categoryandpatient_categoryfields from "Comfort" to an empty string in theConsultationFormandDailyRoundscomponents to avoid pre-selecting a category for the patient and to make it mandatory for the user to choose one (link, link, link, link, link)patient_categoryfield in theDailyRoundscomponent to check if it has a value and if not, add an error message and set theinvalidFormflag to true (link)?.) to check ifres.dataexists before accessing its properties in theDailyRoundscomponent to prevent errors ifres.datais undefined or null (link)