Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligned Service History & Transaction History in Asset Details #6382

Merged
merged 5 commits into from
Oct 9, 2023

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Oct 2, 2023

WHAT

🤖 Generated by Copilot at 8fc261d

The pull request improves the text alignment of the asset transaction and asset service tables in AssetManage.tsx. The changes enhance the readability and aesthetics of the tables by applying design principles.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 8fc261d

  • Align the text of the to_location and performed_by columns in the asset transaction table to the center for readability and consistency (link, link)
  • Align the text of the modified_date column in the asset transaction table to the right to separate it from the edit button and match the serviced_on column in the asset service table (link, link)
  • Align the text of the serviced_on column in the asset service table to the left to match the from_location column in the asset transaction table and create a visual hierarchy of the headers (link, link)
  • Align the edit button in the asset service table to the right to match the edit button in the asset transaction table and balance the table actions (link, link)
  • Align the column headers in both tables to match the corresponding column data and create a visual alignment of the headers (link, link, link)

@GokulramGHV GokulramGHV requested a review from a team October 2, 2023 09:53
@GokulramGHV GokulramGHV requested a review from a team as a code owner October 2, 2023 09:53
@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2023 9:10am

@netlify
Copy link

netlify bot commented Oct 2, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit cbe6ee9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6523c36b59573300087ae19c
😎 Deploy Preview https://deploy-preview-6382--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Oct 3, 2023

@GokulramGHV
image

  • can we move the edit and Moved on to the center

@nihal467
Copy link
Member

nihal467 commented Oct 9, 2023

LGTM

@khavinshankar khavinshankar merged commit 17515b8 into coronasafe:develop Oct 9, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service History & Transaction History is misaligned
3 participants