Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prescriptions: freeze columns and shrink discontinued #6389

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 3, 2023

WHAT

🤖 Generated by Copilot at 10a2352

This pull request adds a feature to toggle discontinued prescriptions in the PrescriptionAdministrationsTable component and enhances its UI and UX. It also updates the type of the query parameter of the list function in PrescriptionActions to make it more generic and flexible.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 10a2352

  • Implement a feature to toggle the visibility of discontinued prescriptions in the table (link, link, link, link)
  • Improve the user experience and the responsiveness of the table (link, link, link, link, link)

@rithviknishad rithviknishad requested a review from a team October 3, 2023 13:40
@rithviknishad rithviknishad requested a review from a team as a code owner October 3, 2023 13:41
@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Oct 3, 2023 1:41pm

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 10a2352
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/651c19eec6dade0008622773
😎 Deploy Preview https://deploy-preview-6389--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad rithviknishad changed the base branch from develop to prescriptions/edit October 3, 2023 13:41
@rithviknishad rithviknishad changed the base branch from prescriptions/edit to develop October 3, 2023 13:41
@cypress
Copy link

cypress bot commented Oct 3, 2023

Passing run #1348 ↗︎

0 78 0 0 Flakiness 0

Details:

Prescriptions: freeze columns and shrink discontinued
Project: CARE Commit: 10a2352a7c
Status: Passed Duration: 03:05 💡
Started: Oct 3, 2023 1:45 PM Ended: Oct 3, 2023 1:48 PM

Review all test suite changes for PR #6389 ↗︎

@nihal467
Copy link
Member

nihal467 commented Oct 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 64c0b24 into develop Oct 5, 2023
61 of 62 checks passed
@khavinshankar khavinshankar deleted the prescriptions/shrink-discontinued2 branch October 5, 2023 07:22
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prescription : Freeze columns Prescriptions Table: Shrink discontinued medicine to one row
3 participants