Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vitals Monitor: Shows relative time for blood pressure and hide if stale (30 mins) #6407

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 6, 2023

WHAT

🤖 Generated by Copilot at a465cce

Added a feature to hide outdated blood pressure data in the HL7PatientVitalsMonitor component. This involved adding a date-time property to the vitals data interfaces and using the dayjs library to compare the timestamps. The affected files were HL7PatientVitalsMonitor.tsx, types.ts, and useHL7VitalsMonitor.ts.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at a465cce

  • Add date-time property to vitals data interfaces to store and access the timestamp of the data (link, link)
  • Import dayjs library and define helper functions to format and check the timestamp of the blood pressure data in HL7PatientVitalsMonitor.tsx (link)
  • Conditionally render the blood pressure values, units, and timestamp based on whether the data is within 30 minutes of the current time using the bpWithinMaxPersistence variable (link, link, link, link)

@rithviknishad rithviknishad requested a review from a team October 6, 2023 04:53
@rithviknishad rithviknishad requested a review from a team as a code owner October 6, 2023 04:53
@netlify
Copy link

netlify bot commented Oct 6, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a465cce
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/651f92c9132427000842ed2b
😎 Deploy Preview https://deploy-preview-6407--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Oct 6, 2023 4:53am

@cypress
Copy link

cypress bot commented Oct 6, 2023

1 failed test on run #1370 ↗︎

1 77 0 0 Flakiness 0

Details:

Vitals Monitor: Shows relative time for blood pressure and hide if stale (30 min...
Project: CARE Commit: a465cce29d
Status: Failed Duration: 02:53 💡
Started: Oct 6, 2023 4:57 AM Ended: Oct 6, 2023 5:00 AM
Failed  cypress/e2e/patient_spec/patient_crud.cy.ts • 1 failed test

View Output Video

Test Artifacts
Patient Creation with consultation > Create a New consultation to existing patient Test Replay Output Screenshots

Review all test suite changes for PR #6407 ↗︎

@nihal467
Copy link
Member

nihal467 commented Oct 6, 2023

LGTM

@khavinshankar khavinshankar merged commit 9d26e02 into develop Oct 6, 2023
55 of 58 checks passed
@khavinshankar khavinshankar deleted the vitals-timestamp branch October 6, 2023 12:10
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants