Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypress Failure in Assets #6421

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Fix Cypress Failure in Assets #6421

merged 1 commit into from
Oct 9, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 9, 2023

WHAT

🤖 Generated by Copilot at 1ea0803

Improved e2e tests for asset homepage by using shortened location names from the API. This affects the file cypress/e2e/assets_spec/asset_homepage.cy.ts.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 1ea0803

  • Shortened location name "Camera Loc" to match backend API changes (link, link)
  • Updated assetFilters.assertLocationText function to assert the shortened name in the asset homepage (link)
  • Updated assetPage.selectImportLocation function to select the shortened name in the asset import page (link)

@nihal467 nihal467 requested a review from a team October 9, 2023 08:14
@nihal467 nihal467 requested a review from a team as a code owner October 9, 2023 08:14
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1ea0803
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6523b6686a3be6000849dbd6
😎 Deploy Preview https://deploy-preview-6421--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Oct 9, 2023 8:14am

@nihal467
Copy link
Member Author

nihal467 commented Oct 9, 2023

LGTM

@cypress
Copy link

cypress bot commented Oct 9, 2023

Passing run #1383 ↗︎

0 78 0 0 Flakiness 0

Details:

Fix Cypress Failure in Assets
Project: CARE Commit: 1ea08033bb
Status: Passed Duration: 03:38 💡
Started: Oct 9, 2023 8:19 AM Ended: Oct 9, 2023 8:22 AM

Review all test suite changes for PR #6421 ↗︎

@khavinshankar khavinshankar merged commit e64138c into develop Oct 9, 2023
58 checks passed
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants