-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes pagination not working in Location Management (PaginatedList
component)
#6462
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Passing run #1465 ↗︎Details:
Review all test suite changes for PR #6462 ↗︎ |
@rithviknishad can you fix the cypress failure |
LGTM |
@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
WHAT
🤖 Generated by Copilot at 330c7d9
Improved pagination logic for
PaginatedList
component. Modified query hook insrc/CAREUI/misc/PaginatedList.tsx
to use offset parameter and fetch only the items for the current page.Proposed Changes
offset
not included in qParams inPaginatedList
component.@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 330c7d9
renderList
function to use thedata.results
array instead of thedata
array (link)total
prop to the PaginatedList component to display the total number of items (link)total
prop in thePagination
component to calculate the number of pages (link)