Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Search using username | User Tab #6478

Merged
merged 2 commits into from
Oct 20, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 19, 2023

WHAT

🤖 Generated by Copilot at 8520673

This pull request adds end-to-end tests and page objects for the user homepage feature, which allows searching by username. It also adds id attributes to the FilterBadge and search input elements in the FilterBadge.tsx and ManageUsers.tsx files to enable the tests.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 8520673

  • Add an end-to-end test file for the user homepage feature (link)
  • Import modules and page objects (link)
  • Set up login and local storage hooks (link)
  • Define a test case for searching by username (link)
    • Verify the visibility and functionality of the search input, the username text and badge, and the remove icon (link)
  • Add a page object class for the user homepage feature (link)
    • Define element selectors and methods for interacting with the user homepage elements (link)
  • Add id attributes to the FilterBadge and search input elements in the display and Components modules (link, link)
    • Use the id attributes to identify the elements for the user homepage feature (link, link)
    • Match the id attributes to the selectors defined in the page object class (link, link)

@nihal467 nihal467 requested a review from a team October 19, 2023 20:58
@nihal467 nihal467 requested a review from a team as a code owner October 19, 2023 20:58
@vercel
Copy link

vercel bot commented Oct 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 9:11pm

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit dc4359b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65319b57b2836d00097abfb8
😎 Deploy Preview https://deploy-preview-6478--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Oct 19, 2023

Passing run #1444 ↗︎

0 80 0 0 Flakiness 0

Details:

New Cypress Test | Search using username | User Tab
Project: CARE Commit: dc4359b56d
Status: Passed Duration: 09:27 💡
Started: Oct 19, 2023 9:24 PM Ended: Oct 19, 2023 9:33 PM

Review all test suite changes for PR #6478 ↗︎

@khavinshankar khavinshankar merged commit 9eac85c into develop Oct 20, 2023
54 checks passed
@khavinshankar khavinshankar deleted the username-search branch October 20, 2023 01:03
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Ashesh3 pushed a commit that referenced this pull request Oct 20, 2023
* Username search cypress test

* import error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining Cypress Test related to User Management
2 participants