Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure eslint for mdx files. Closes #3760 #6485

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

Omkar76
Copy link
Contributor

@Omkar76 Omkar76 commented Oct 24, 2023

WHAT

🤖 Generated by Copilot at 5bff4a9

This pull request enhances the Storybook documentation for the project by enabling ESLint linting for .mdx files and fixing some minor issues in the Introduction.mdx file. It also cleans up the ESLint configuration and dependencies in .eslintrc.json and package.json.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 5bff4a9

  • Add and configure MDX plugin for ESLint to lint .mdx files (link, link, link)
  • Remove redundant and conflicting ESLint configuration from package.json (link, link)
  • Add rel="noreferrer" attribute to links that open in a new tab in Introduction.mdx (link, link, link)
  • Remove extra space character from Introduction.mdx (link)

@Omkar76 Omkar76 requested a review from a team October 24, 2023 10:28
@Omkar76 Omkar76 requested a review from a team as a code owner October 24, 2023 10:28
@vercel
Copy link

vercel bot commented Oct 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2023 10:29am

@netlify
Copy link

netlify bot commented Oct 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5bff4a9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65379c58ea030f0008e32028
😎 Deploy Preview https://deploy-preview-6485--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar khavinshankar merged commit e17e746 into coronasafe:develop Oct 27, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants