Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix phone number parsing issue in abdm #6496

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Oct 26, 2023

WHAT

🤖 Generated by Copilot at 5303d73

Updated the phone number parsing function in PatientRegister.tsx to use the Indian country code. This improves the phone number validation and formatting for the patient registration form.

Proposed Changes

  • Fixes the issue of the Patient Registration page going blank while trying to link the ABHA number.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 5303d73

  • Updated the parsePhoneNumber function to accept a country code and set it to "IN" for India (link)

@khavinshankar khavinshankar requested a review from a team October 26, 2023 06:37
@khavinshankar khavinshankar requested a review from a team as a code owner October 26, 2023 06:37
@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Oct 26, 2023 6:38am

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5303d73
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653a09488664ab0008ccb5df
😎 Deploy Preview https://deploy-preview-6496--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@khavinshankar khavinshankar added urgent P1 breaking issue or vital feature ABDM needs testing labels Oct 26, 2023
@cypress
Copy link

cypress bot commented Oct 26, 2023

Passing run #1471 ↗︎

0 85 0 0 Flakiness 0

Details:

fix phone number parsing issue in abdm
Project: CARE Commit: 5303d73de4
Status: Passed Duration: 03:12 💡
Started: Oct 26, 2023 6:44 AM Ended: Oct 26, 2023 6:47 AM

Review all test suite changes for PR #6496 ↗︎

@nihal467
Copy link
Member

LGTM

@gigincg gigincg merged commit 61a54e7 into develop Oct 26, 2023
61 checks passed
@github-actions
Copy link

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@khavinshankar khavinshankar deleted the fix-abdm-phone-issue branch October 26, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ABDM P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants