Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added LiveFeedScreen page #6497

Merged
merged 10 commits into from
Nov 7, 2023
Merged

Conversation

kshitijv256
Copy link
Contributor

@kshitijv256 kshitijv256 commented Oct 26, 2023

WHAT

🤖 Generated by Copilot at 6b62f09

This pull request adds a new feature to the facility dashboard, which allows users to view the live camera feed of the facility and its patient asset beds. It creates a new LiveFeedScreen component, a new route, and some TypeScript fixes. It also imports the ConsultationModel type to the src/Redux/api.tsx file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
@gigincg

Screenshots

imageedit_1_6895600569
Screenshot from 2023-10-31 13-43-33
Screenshot from 2023-10-31 13-45-11

@vercel
Copy link

vercel bot commented Oct 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2023 11:10am

@netlify
Copy link

netlify bot commented Oct 26, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ce798db
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654a1af51152e800081731e4
😎 Deploy Preview https://deploy-preview-6497--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kshitijv256 kshitijv256 marked this pull request as ready for review October 26, 2023 09:35
@kshitijv256 kshitijv256 requested a review from a team October 26, 2023 09:35
@kshitijv256 kshitijv256 requested a review from a team as a code owner October 26, 2023 09:35
@nihal467
Copy link
Member

@kshitijv256 add screenshot / video of what you have made in the PR for QA testing

@nihal467 nihal467 added the question Further information is requested label Oct 31, 2023
@kshitijv256
Copy link
Contributor Author

@kshitijv256 add screenshot / video of what you have made in the PR for QA testing

updated PR description with screenshots

@kshitijv256
Copy link
Contributor Author

I Have not added user access control, should be better to add in a separate PR

changed UI as livefeed in consultation

@nihal467
Copy link
Member

nihal467 commented Nov 6, 2023

@kshitijv256
image

the tooltip is overlapping with the sidebar

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much code duplication in this PR.

src/Components/Facility/LiveFeedTile.tsx Show resolved Hide resolved
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Momentarily approving. Will create a separate issue to clean this up and improve the UI.

@kshitijv256
Copy link
Contributor Author

kshitijv256 commented Nov 6, 2023

@nihal467

the tooltip is overlapping with the sidebar

Screenshot from 2023-11-06 22-31-23

Moved controls to center of tile

package-lock.json Outdated Show resolved Hide resolved
@khavinshankar
Copy link
Member

@rithviknishad can you re-review this once

@rithviknishad
Copy link
Member

Done @khavinshankar

@khavinshankar khavinshankar merged commit c94a54c into coronasafe:develop Nov 7, 2023
33 of 35 checks passed
@kshitijv256 kshitijv256 deleted the camerafeed branch December 4, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hub Camera Monitoring Screen
4 participants