Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› οΈ βœ… Fixed Responsiveness Issue in Facility List Page / Facility Card #6507

Merged

Conversation

shyamprakash123
Copy link
Contributor

@shyamprakash123 shyamprakash123 commented Oct 27, 2023

WHAT

πŸ€– Generated by Copilot at 6986ac2

Improved the responsiveness and layout of the FacilityCard component by applying tailwind classes. Fixed the image overflow issue by adding overflow-hidden to the container div.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Before Fix:

Screenshot 2023-10-27 201131

After Fix:

Screenshot 2023-10-27 201146

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

πŸ€– Generated by Copilot at 6986ac2

  • Add overflow-hidden class to outer div of facility card to prevent image overflow (link, link)
  • Add min-w-[15%] class to link element to ensure minimum width for image on smaller screens (link, link)
  • Add flex-wrap class to various divs to allow content to wrap on smaller screens and avoid overflow or overlap (link, link, link, link)
  • Add flex class to div that contains facility actions to enable wrapping (link)

@shyamprakash123 shyamprakash123 requested a review from a team October 27, 2023 14:58
@shyamprakash123 shyamprakash123 requested a review from a team as a code owner October 27, 2023 14:58
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
care-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 27, 2023 2:59pm

@netlify
Copy link

netlify bot commented Oct 27, 2023

βœ… Deploy Preview for care-egov-staging ready!

Name Link
πŸ”¨ Latest commit 6986ac2
πŸ” Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653bd021961dcd0008661635
😎 Deploy Preview https://deploy-preview-6507--care-egov-staging.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 66aa48b into coronasafe:develop Oct 30, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsiveness Issue in Facility List Page / Facility Card
4 participants