Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ› οΈ βœ… Fixed User signout flow malfunctioning. #6509

Merged

Conversation

shyamprakash123
Copy link
Contributor

@shyamprakash123 shyamprakash123 commented Oct 27, 2023

WHAT

πŸ€– Generated by Copilot at a735229

Fixed a sign out bug that caused the user to stay on the same page instead of being redirected to the login page. Changed handleSignOut function in src/Utils/utils.ts to use window.location.href instead of window.location.reload.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

πŸ€– Generated by Copilot at a735229

  • Fix sign out caching issue by using window.location.href instead of window.location.reload when forceReload is true (link)

@shyamprakash123 shyamprakash123 requested a review from a team October 27, 2023 17:41
@shyamprakash123 shyamprakash123 requested a review from a team as a code owner October 27, 2023 17:41
@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
care-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 27, 2023 5:42pm

@netlify
Copy link

netlify bot commented Oct 27, 2023

βœ… Deploy Preview for care-egov-staging ready!

Name Link
πŸ”¨ Latest commit a735229
πŸ” Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653bf6467e4d24000898a2cd
😎 Deploy Preview https://deploy-preview-6509--care-egov-staging.netlify.app/
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shyamprakash123 shyamprakash123 changed the title πŸ› οΈ βœ… Fixed User signout flow mafunctioning. πŸ› οΈ βœ… Fixed User signout flow malfunctioning. Oct 28, 2023
@nihal467
Copy link
Member

LGTM @rithviknishad can you review it

@khavinshankar khavinshankar merged commit edd6a7e into coronasafe:develop Oct 30, 2023
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User signout flow is mafunctioning
4 participants