Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Advance Filters Functionality | User Tab #6510

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 28, 2023

WHAT

🤖 Generated by Copilot at d4804eb

Added and updated Cypress tests for user management features. Added a test case for user advance filter in user_homepage.cy.ts and new methods to UserPage class in UserSearch.ts. Fixed phone number data type in user_crud.cy.ts.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at d4804eb

  • Change phone numbers from numbers to strings in user management tests (link)
  • Import phone numbers from user_crud file and rename describe block to User Homepage in user_homepage.cy.ts (link)
  • Add test case to check user advance filter functionality in user_homepage.cy.ts (link)
  • Add method to verify URL after applying advance filters in UserSearch.ts (link)
  • Add methods to interact and assert advance filters in UserSearch.ts (link)

@nihal467 nihal467 requested a review from a team October 28, 2023 11:21
@nihal467 nihal467 requested a review from a team as a code owner October 28, 2023 11:21
@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 092b4d2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653f4d38b1461900087ff313
😎 Deploy Preview https://deploy-preview-6510--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 6:29am

@cypress
Copy link

cypress bot commented Oct 28, 2023

2 failed tests on run #1493 ↗︎

2 84 0 0 Flakiness 0

Details:

New Cypress Test | Advance Filters Functionality | User Tab
Project: CARE Commit: 092b4d2f56
Status: Failed Duration: 03:35 💡
Started: Oct 30, 2023 6:33 AM Ended: Oct 30, 2023 6:37 AM
Failed  cypress/e2e/patient_spec/patient_crud.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Patient Creation with consultation > Create a New consultation to existing patient Test Replay Output Screenshots
Patient Creation with consultation > Edit created consultation to existing patient Test Replay Output Screenshots

Review all test suite changes for PR #6510 ↗︎

@khavinshankar khavinshankar merged commit c074144 into develop Oct 30, 2023
53 of 56 checks passed
@khavinshankar khavinshankar deleted the new-test-advance-filter branch October 30, 2023 06:51
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants