Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Existing Cypress POM Conversion | Page Navigation | User Tab #6511

Merged
merged 4 commits into from
Oct 30, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 28, 2023

WHAT

🤖 Generated by Copilot at 0ed61fe

The pull request adds and updates Cypress tests for the user homepage and the user CRUD features. It also fixes some minor issues with the phone number format and the test naming. The main files affected are user_crud.cy.ts, user_homepage.cy.ts, and UserSearch.ts.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 0ed61fe

  • Change phone_number and alt_phone_number variables from numbers to strings to match API format (link)
  • Add phone_number and alt_phone_number variables to User Homepage describe block (link)
  • Add test case for User advance filter functionality to user_homepage.cy.ts, using the new variables and verifying the URL and the data displayed after applying and clearing the filter (link)
  • Add methods to UserPage class in UserSearch.ts to interact with the advanced filter elements and verify the data and URL (link, link)
  • Remove duplicate test case for Next/Previous Page Navigation from user_crud.cy.ts (link)
  • Add test case for Next/Previous Page Navigation to user_homepage.cy.ts, using the methods from UserSearch.ts to navigate between pages and verify the current page number in the URL (link)

@nihal467 nihal467 requested a review from a team October 28, 2023 11:49
@nihal467 nihal467 requested a review from a team as a code owner October 28, 2023 11:49
@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8775b3c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653f62f15509790009345428
😎 Deploy Preview https://deploy-preview-6511--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2023 8:03am

@cypress
Copy link

cypress bot commented Oct 28, 2023

Passing run #1495 ↗︎

0 86 0 0 Flakiness 0

Details:

Existing Cypress POM Conversion | Page Navigation | User Tab
Project: CARE Commit: 8775b3cfe7
Status: Passed Duration: 03:19 💡
Started: Oct 30, 2023 8:06 AM Ended: Oct 30, 2023 8:09 AM

Review all test suite changes for PR #6511 ↗︎

@github-actions
Copy link

👋 Hi, @nihal467,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 30, 2023
@khavinshankar khavinshankar merged commit d1d863e into develop Oct 30, 2023
55 of 56 checks passed
@khavinshankar khavinshankar deleted the convert-pom-pagination branch October 30, 2023 08:54
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants