Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Existing User Profile Updation | User Tab #6527

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Oct 30, 2023

WHAT

🤖 Generated by Copilot at 11f3795

This pull request improves the user creation and user profile test specs by adding constants, new test cases, and helper methods. It also adds id attributes to some components to make them more testable. The affected files are cypress/e2e/users_spec/user_creation.cy.ts, src/Components/Users/UserProfile.tsx, cypress/pageobject/Users/UserCreation.ts, and src/Components/Common/Sidebar/SidebarUserCard.tsx.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 11f3795

  • Add id attributes to various user profile components to facilitate testing (link, link, link, link, link, link, link, link, link, link, link)
  • Import phone number constants from UserCreation.ts page object file and use them in user_creation.cy.ts test spec (link, link)
  • Add helper methods to UserCreation.ts page object class for typing and clearing elements by id (link)
  • Add test cases to user_creation.cy.ts test spec for updating and validating user profile with valid and invalid data (link)
  • Define error messages array for user profile form validation test case in user_creation.cy.ts test spec (link)
  • Remove commented out code from user_creation.cy.ts test spec (link)

@nihal467 nihal467 requested a review from a team October 30, 2023 18:03
@nihal467 nihal467 requested a review from a team as a code owner October 30, 2023 18:03
@nihal467 nihal467 requested a review from bodhish October 30, 2023 18:03
@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 11f3795
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/653fefdf8bec9700074ecce7
😎 Deploy Preview https://deploy-preview-6527--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Oct 30, 2023 6:03pm

@cypress
Copy link

cypress bot commented Oct 30, 2023

Passing run #1499 ↗︎

0 82 0 0 Flakiness 0

Details:

New Cypress Test | Existing User Profile Updation | User Tab
Project: CARE Commit: 11f37954f6
Status: Passed Duration: 03:13 💡
Started: Oct 30, 2023 6:08 PM Ended: Oct 30, 2023 6:11 PM

Review all test suite changes for PR #6527 ↗︎

@khavinshankar khavinshankar merged commit 7703f1f into develop Oct 30, 2023
60 of 61 checks passed
@github-actions
Copy link

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants