Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☑️ Added Loading component while the assets are being fetched. #6532

Merged

Conversation

shyamprakash123
Copy link
Contributor

@shyamprakash123 shyamprakash123 commented Nov 1, 2023

WHAT

🤖 Generated by Copilot at 7f9b7d0

Improved loading feedback for assets list and count card. Added loading state and components to AssetsList.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 7f9b7d0

  • Add loading state variable to track the loading status of the assets list query (link)
  • Render Loading component when the assets list query is loading, instead of showing an empty list (link)
  • Pass loading state variable to CountCard component to show loading indicator when the total assets count is loading (link)

@shyamprakash123 shyamprakash123 requested a review from a team November 1, 2023 15:15
@shyamprakash123 shyamprakash123 requested a review from a team as a code owner November 1, 2023 15:15
Copy link

vercel bot commented Nov 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 1, 2023 3:16pm

Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7f9b7d0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65426b9e04a0260008037397
😎 Deploy Preview https://deploy-preview-6532--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Nov 6, 2023

LGTM

@khavinshankar khavinshankar merged commit 585cb5a into coronasafe:develop Nov 7, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Page loader to the asset list tab
4 participants