Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix responsive issue in sidebar #6547

Merged
merged 1 commit into from
Nov 8, 2023
Merged

fix responsive issue in sidebar #6547

merged 1 commit into from
Nov 8, 2023

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Nov 6, 2023

WHAT

🤖 Generated by Copilot at 62c5941

Fixed sidebar height bug and improved layout in Sidebar.tsx. This makes the sidebar more responsive and consistent across different screen sizes.

Proposed Changes

Before:
image

After:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 62c5941

  • Fix sidebar overflow bug by changing height class to h-full (link)
  • Remove unnecessary bottom margin from sidebar menu items (link)

@khavinshankar khavinshankar requested a review from a team November 6, 2023 07:55
@khavinshankar khavinshankar requested a review from a team as a code owner November 6, 2023 07:55
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Nov 6, 2023 7:55am

Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 62c5941
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65489bf5c3c2940008577ed7
😎 Deploy Preview https://deploy-preview-6547--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 6, 2023

Passing run #1521 ↗︎

0 82 0 0 Flakiness 0

Details:

fix responsive issue in sidebar
Project: CARE Commit: 62c5941caa
Status: Passed Duration: 03:00 💡
Started: Nov 6, 2023 7:59 AM Ended: Nov 6, 2023 8:02 AM

Review all test suite changes for PR #6547 ↗︎

@nihal467
Copy link
Member

nihal467 commented Nov 6, 2023

LGTM

@gigincg gigincg merged commit c8e5c94 into develop Nov 8, 2023
65 of 66 checks passed
Copy link

github-actions bot commented Nov 8, 2023

@khavinshankar We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to access signout in some mobile screens
4 participants