Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Multiple duplicate API requests dispatched to fetch resource comments #6562

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Fixed Multiple duplicate API requests dispatched to fetch resource comments #6562

merged 3 commits into from
Nov 8, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Nov 7, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 06edc6a

Refactored the comment section of the resource page to use a reusable pagination component. Simplified the code by removing unused code.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 06edc6a

  • Refactor CommentSection component to use PaginatedList component for fetching and rendering comments (link, link, link)

@konavivekramakrishna konavivekramakrishna requested a review from a team November 7, 2023 12:04
@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner November 7, 2023 12:04
@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 2:03pm

@netlify Netlify
Copy link

netlify bot commented Nov 7, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f007816
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654b95208f0db30008a83728
😎 Deploy Preview https://deploy-preview-6562--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

rithviknishad
rithviknishad approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick! Nice work!

@nihal467
Copy link
Member

nihal467 commented Nov 8, 2023

LGTM

@khavinshankar khavinshankar merged commit 05df8c0 into coronasafe:develop Nov 8, 2023
33 of 35 checks passed
@konavivekramakrishna konavivekramakrishna deleted the test#6556 branch November 8, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple duplicate API requests dispatched to fetch resource comments
4 participants
@konavivekramakrishna @nihal467 @rithviknishad @khavinshankar