Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Functionality test of Linking and Unlinking Facility | User Tab #6564

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Nov 8, 2023

WHAT

🤖 Generated by Copilot at bc60aab

This pull request adds id attributes to various elements in the frontend components, and adds a new test file and a new page object file for the user manage feature. The id attributes are needed for testing purposes, and the new test file and page object file test the functionality of linking and unlinking facilities for users. The pull request also removes some unused code and adds id attributes to some elements in the facility and patient components.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at bc60aab

  • Add new test file and page object file for user manage feature, which covers linking and unlinking facilities for multiple users and verifying the changes in user cards and doctor connect feature (link, link)
  • Remove unused commented out code block from user creation test file (link)
  • Add id attributes to various elements in the facility card, facility home, patient manager, user facilities, and doctor video slide over components, which are used for locating the elements in the test file (link, link, link, link, link, link, link, link, link, link)

@nihal467 nihal467 requested a review from a team November 8, 2023 08:31
@nihal467 nihal467 requested a review from a team as a code owner November 8, 2023 08:31
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bef5fd1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654b531b0775b5000823969b
😎 Deploy Preview https://deploy-preview-6564--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 9:22am

Copy link

cypress bot commented Nov 8, 2023

Passing run #1540 ↗︎

0 83 0 0 Flakiness 0

Details:

New Cypress Test | Functionality test of Linking and Unlinking Facility | User T...
Project: CARE Commit: bef5fd1f9a
Status: Passed Duration: 03:23 💡
Started: Nov 8, 2023 9:25 AM Ended: Nov 8, 2023 9:28 AM

Review all test suite changes for PR #6564 ↗︎

@khavinshankar khavinshankar merged commit 6c4f151 into develop Nov 8, 2023
55 of 58 checks passed
@khavinshankar khavinshankar deleted the manage-user-cypress branch November 8, 2023 09:31
Copy link

github-actions bot commented Nov 8, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@nihal467 nihal467 linked an issue Nov 8, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining Cypress Test related to User Management
3 participants