Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Cypress Test | Functionality test of Linking Skill to a User | User Tab #6568

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented Nov 8, 2023

WHAT

🤖 Generated by Copilot at 0a8ad05

Added id props to some components related to user skills and updated the test cases for user management features. The id props help to identify and interact with the skill elements in the test cases. The test cases cover the linking and unlinking of skills for users and doctors and the verification of the skills in the user profile and doctor connect. The files affected are cypress/e2e/users_spec/user_manage.cy.ts, src/Components/Common/SkillSelect.tsx, src/Components/Form/AutoCompleteAsync.tsx, src/Components/Users/SkillsSlideOver.tsx, cypress/pageobject/Users/ManageUserPage.ts, src/Components/Users/SkillsSlideOverComponents.tsx, and src/Components/Users/UserProfile.tsx.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 0a8ad05

  • Add optional id prop to SkillSelect and AutoCompleteAsync components to enable locating them in test cases (link, link, link, link, link, link)
  • Pass id prop to SkillSelect and button elements in SkillsSlideOver component to allow selecting and adding skills for a user (link, link)
  • Pass id prop to div element in SkillsSlideOver component to display the list of skills added to a user (link)
  • Pass id prop to button element in SkillsArray component to enable removing skills from a user (link)
  • Pass id prop to div element in UserProfile component to show the skills linked to a user profile (link)
  • Change constants in user_manage.cy.ts file to use different users for testing linking and unlinking of skills and setting of working hours (link)
  • Add test cases in user_manage.cy.ts file to verify linking of skills for a user and its reflection in user profile and doctor connect feature (link)
  • Add methods in ManageUserPage class in ManageUserPage.ts file to interact with elements related to linking and unlinking of skills (link)

@nihal467 nihal467 requested a review from a team November 8, 2023 19:13
@nihal467 nihal467 requested a review from a team as a code owner November 8, 2023 19:13
Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 11:39am

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6046317
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654cc4de161b9f000886e29f
😎 Deploy Preview https://deploy-preview-6568--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 8, 2023

Passing run #1553 ↗︎

0 85 0 0 Flakiness 0

Details:

New Cypress Test | Functionality test of Linking Skill to a User | User Tab
Project: CARE Commit: 604631792f
Status: Passed Duration: 02:40 💡
Started: Nov 9, 2023 11:42 AM Ended: Nov 9, 2023 11:45 AM

Review all test suite changes for PR #6568 ↗︎

@khavinshankar khavinshankar merged commit f7ac211 into develop Nov 9, 2023
57 of 58 checks passed
@khavinshankar khavinshankar deleted the skill-manage-user branch November 9, 2023 12:27
Copy link

github-actions bot commented Nov 9, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remaining Cypress Test related to User Management
2 participants