Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cypress: resource and sample test #6569

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 9, 2023

WHAT

🤖 Generated by Copilot at edd2c04

Fixed a bug in resource list view that prevented accessing some resource details. Changed the button onClick handler to use id instead of external_id in src/Components/Resource/ListView.tsx.

Proposed Changes

  • Fixes #issue?
  • Change 1
  • Change 2
  • More?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at edd2c04

  • Fix a bug where some resources could not be accessed from the list view by using the id property instead of the external_id property for the onClick handler of the button that navigates to the resource details page (link)

@rithviknishad rithviknishad requested a review from a team November 9, 2023 09:39
@rithviknishad rithviknishad requested a review from a team as a code owner November 9, 2023 09:39
Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1bdebff
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/654cab886206330008b42d44
😎 Deploy Preview https://deploy-preview-6569--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 9, 2023 9:51am

Copy link

cypress bot commented Nov 9, 2023

2 failed tests on run #1549 ↗︎

2 82 0 0 Flakiness 0

Details:

fix resource details page from navigating to undefined
Project: CARE Commit: 1bdebfff21
Status: Failed Duration: 03:19 💡
Started: Nov 9, 2023 10:08 AM Ended: Nov 9, 2023 10:11 AM
Failed  cypress/e2e/patient_spec/patient_crud.cy.ts • 2 failed tests

View
Output

Test Artifacts
Patient Creation with consultation > Create a New consultation to existing patient Test Replay Screenshots
Patient Creation with consultation > Edit created consultation to existing patient Test Replay Screenshots

Review all test suite changes for PR #6569 ↗︎

@rithviknishad rithviknishad changed the title fix resource details page from navigating to undefined fix cypress: resource and sample test Nov 9, 2023
@rithviknishad rithviknishad added the P1 breaking issue or vital feature label Nov 9, 2023
@nihal467
Copy link
Member

nihal467 commented Nov 9, 2023

LGTM

@khavinshankar khavinshankar merged commit 88c64b7 into develop Nov 9, 2023
42 of 59 checks passed
@khavinshankar khavinshankar deleted the patch/resource-id branch November 9, 2023 10:14
Copy link

github-actions bot commented Nov 9, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants