Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪛 Fixed Non-uniform height of Asset List Tiles. #6578

Merged

Conversation

shyamprakash123
Copy link
Contributor

@shyamprakash123 shyamprakash123 commented Nov 9, 2023

WHAT

🤖 Generated by Copilot at ef18c68

Improved the UI of the assets list component by adjusting the link height. Modified the className attribute of the Link component in src/Components/Assets/AssetsList.tsx.

Proposed Changes

Changes

Before:

Screenshot 2023-11-09 234731

After:

Screenshot 2023-11-09 234741

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at ef18c68

  • Added h-full class to Link component to fill parent height (link)

@shyamprakash123 shyamprakash123 requested a review from a team November 9, 2023 18:24
@shyamprakash123 shyamprakash123 requested a review from a team as a code owner November 9, 2023 18:24
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 3:07pm

Copy link

netlify bot commented Nov 9, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b32b243
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6557817363e5690008f751b5
😎 Deploy Preview https://deploy-preview-6578--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 4827e50 into coronasafe:develop Nov 21, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset List Tile: Non-uniform height
4 participants