Fixed Flaky Cypress Test in the User_Manage File #6583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #1565 ↗︎
Details:
Review all test suite changes for PR #6583 ↗︎ |
|||||||||||||||
khavinshankar
approved these changes
Nov 10, 2023
|
@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌. |
There was a problem hiding this comment.
@nihal467 you've changed the package.json, but have not committed the package-lock changes.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 352f326
The pull request enhances the test code for user management by using a class for user creation, adding more steps and assertions to a test case, and waiting for the users API response before navigating to the profile page. The changes affect the files
cypress/e2e/users_spec/user_manage.cy.tsandcypress/pageobject/Users/ManageUserPage.ts.Proposed Changes
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 352f326
UserCreationPageclass to access user creation and verification methods (link)UserCreationPageclass and assign it to theuserCreationPagevariable (link)user_manage.cy.ts(link)navigateToProfilemethod inManageUserPage.tsto intercept and wait for the users API request and assert that the response status code is 200 (link)