Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced useDispatch w. useQuery/request: Users (src/Components/Users/**) [5 out of 5 components] #6596

Merged
merged 31 commits into from
Dec 6, 2023

Conversation

thedevildude
Copy link
Contributor

@thedevildude thedevildude commented Nov 14, 2023

WHAT

🤖 Generated by Copilot at 7a7ad19

Refactored the user-related components and API routes to use custom hooks and models instead of redux actions and dispatches. Added GenderType and weekly_working_hours to user models in models.tsx to enhance user profile data. Improved type safety and readability of API calls in api.tsx by adding TRes and method properties.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at 7a7ad19

@thedevildude thedevildude requested a review from a team November 14, 2023 05:13
@thedevildude thedevildude requested a review from a team as a code owner November 14, 2023 05:13
Copy link

vercel bot commented Nov 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 30, 2023 5:13am

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7cc2c75
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656819c0ec8232000838c175
😎 Deploy Preview https://deploy-preview-6596--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rithviknishad
Copy link
Member

@thedevildude is this PR ready for review?

@thedevildude
Copy link
Contributor Author

No @rithviknishad it needs few more commits. Should by ready by tomorrow's EOD

@nihal467
Copy link
Member

@thedevildude #6652 solve this issue as well along with this PR

@thedevildude
Copy link
Contributor Author

@nihal467 Yeah sure, I'll work on this too

@rithviknishad rithviknishad linked an issue Nov 17, 2023 that may be closed by this pull request
@nihal467
Copy link
Member

LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 29, 2023
Copy link

👋 Hi, @thedevildude,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@khavinshankar
Copy link
Member

@thedevildude fix the merge conflicts

src/Redux/api.tsx Outdated Show resolved Hide resolved
Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com>
@khavinshankar khavinshankar merged commit a6ed2bc into coronasafe:develop Dec 6, 2023
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants