Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dosage field malfunctioning. #6626

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

AshrafMd-1
Copy link
Contributor

@AshrafMd-1 AshrafMd-1 commented Nov 15, 2023

WHAT

🤖 Generated by Copilot at 9c69617

Fixed a bug in the NumericWithUnitsFormField component that caused incorrect values to be displayed and stored. Changed the field.handleChange function to use numeric values instead of strings.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 9c69617

  • Fix a bug in the numeric with units form field component that caused incorrect values to be displayed and stored (link)

@AshrafMd-1 AshrafMd-1 requested a review from a team November 15, 2023 10:08
@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner November 15, 2023 10:08
Copy link

netlify bot commented Nov 15, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9c69617
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6554989edd3aac00081721a6
😎 Deploy Preview https://deploy-preview-6626--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 10:09am

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Nov 15, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 03b8e0a into coronasafe:develop Nov 15, 2023
39 of 41 checks passed
@AshrafMd-1 AshrafMd-1 deleted the Fix-#6625 branch November 15, 2023 12:09
@cypress cypress bot mentioned this pull request Nov 15, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dosage field in prescription are malfunctioning
4 participants