Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mandatory for Rhythm field #6662

Conversation

shyamprakash123
Copy link
Contributor

@shyamprakash123 shyamprakash123 commented Nov 17, 2023

WHAT

🤖[deprecated] Generated by Copilot at ee25c50

Removed required attribute from spo2 field in daily rounds form. This fixes a bug that prevented the form from submitting when spo2 was not entered.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at ee25c50

  • Remove required attribute from spo2 field in daily rounds form to allow submission without spo2 value (link)

@shyamprakash123 shyamprakash123 requested a review from a team November 17, 2023 15:24
@shyamprakash123 shyamprakash123 requested a review from a team as a code owner November 17, 2023 15:24
Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 3:25pm

Copy link

netlify bot commented Nov 17, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ee25c50
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/655785ad426d84000805917f
😎 Deploy Preview https://deploy-preview-6662--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 0ec5cfb into coronasafe:develop Nov 22, 2023
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove the "*" from the rhythm field in the patient normal log update
4 participants