Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout issue in DailyRoundsList component #6709

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Nov 24, 2023

WHAT

🤖[deprecated] Generated by Copilot at bae3e2c

Improved the UI of the daily rounds list component for consultations. Refactored the code in DailyRoundsList.tsx to use better spacing and alignment.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖[deprecated] Generated by Copilot at bae3e2c

  • Reduce the top margin of the daily rounds list to remove extra space (link)
  • Remove the horizontal margin of the daily rounds list to make it span the full width on smaller devices (link)

@Ashesh3 Ashesh3 requested a review from a team November 24, 2023 11:18
@Ashesh3 Ashesh3 requested a review from a team as a code owner November 24, 2023 11:18
@Ashesh3 Ashesh3 requested a review from gigincg November 24, 2023 11:18
Copy link

vercel bot commented Nov 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 24, 2023 11:18am

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bae3e2c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65608678f27aaf0008f4a6c3
😎 Deploy Preview https://deploy-preview-6709--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Nov 24, 2023

1 failed test on run #1612 ↗︎

1 84 0 0 Flakiness 0

Details:

Fix layout issue in DailyRoundsList component
Project: CARE Commit: bae3e2c8bc
Status: Failed Duration: 02:29 💡
Started: Nov 24, 2023 11:21 AM Ended: Nov 24, 2023 11:24 AM
Failed  cypress/e2e/death_report_spec/death_report.cy.ts • 1 failed test

View Output

Test Artifacts
Death Report > Add Data And Submit devdistrictadmin Test Replay Screenshots

Review all test suite changes for PR #6709 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 392fbd5 into develop Nov 24, 2023
61 of 64 checks passed
@khavinshankar khavinshankar deleted the daily-rounds-design-fix branch November 24, 2023 11:33
Copy link

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants