Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the red asterisk from Review field on Log update #6737

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Nov 27, 2023

WHAT

🤖[deprecated] Generated by Copilot at 85754e2

Removed the required attribute from the spo2 field in DailyRounds.tsx to allow submitting the form without a pulse oximeter reading. This fixes the issue #1729.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 85754e2

  • Remove the required attribute from the spo2 field in the daily round form (link). This allows the user to submit the form without entering the spo2 value, as reported in issue added result filter in SampleTest #1729. The file src/Components/Patient/DailyRounds.tsx contains this change.

@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner November 27, 2023 22:34
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 10:35pm

Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 85754e2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6565197893b13b0008d19227
😎 Deploy Preview https://deploy-preview-6737--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@konavivekramakrishna konavivekramakrishna changed the title Remove the red asterisk from Review field on Log update Removed the red asterisk from Review field on Log update Nov 27, 2023
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit fc1f1a9 into coronasafe:develop Nov 29, 2023
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review after: Log Update
4 participants