Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix responsiveness on patients page #6759

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Nov 30, 2023

WHAT

🤖[deprecated] Generated by Copilot at 9083467

Improved the responsiveness and layout of the patient manager component by adding flex classes to the patient name and age div in ManagePatients.tsx.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 9083467

  • Prevent patient name and age from overflowing to the next line on smaller screens by adding flex flex-wrap classes to the div element with the font-semibold class (link)

@Pranshu1902 Pranshu1902 requested a review from a team as a code owner November 30, 2023 12:38
Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2023 10:36am

Copy link

netlify bot commented Nov 30, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 09e4c9d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65704e7489f5ac0008bdd180
😎 Deploy Preview https://deploy-preview-6759--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Dec 5, 2023

image

@Pranshu1902 in the responsive view, when it goes to the second row, move it to the left side and remove the space

@Pranshu1902
Copy link
Contributor Author

@nihal467 Removed left margin
Updated view:
image

@nihal467
Copy link
Member

nihal467 commented Dec 6, 2023

LGTM

@khavinshankar khavinshankar merged commit f8aae49 into coronasafe:develop Dec 13, 2023
32 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper responsiveness in Patient Card
3 participants