Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #6766; Misaligned label in external results #6769

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 1, 2023

WHAT

🤖[deprecated] Generated by Copilot at 04e726d

Simplify and improve accessibility of the label for the phone number input field in ResultList.tsx. Use the existing PhoneNumberFormField component with a label prop instead of a separate div element.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 04e726d

  • Simplify the markup and improve the accessibility of the phone number search field by passing the label text as a prop to the PhoneNumberFormField component (link)

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 04e726d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6569fce000c9e10008a38eaf
😎 Deploy Preview https://deploy-preview-6769--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 3:34pm

Copy link

cypress bot commented Dec 1, 2023

Passing run #1655 ↗︎

0 88 0 0 Flakiness 0

Details:

fixes #6766; Misaligned label in external results
Project: CARE Commit: 04e726dcc6
Status: Passed Duration: 02:14 💡
Started: Dec 1, 2023 3:37 PM Ended: Dec 1, 2023 3:39 PM

Review all test suite changes for PR #6769 ↗︎

@nihal467
Copy link
Member

nihal467 commented Dec 1, 2023

LGTM

@khavinshankar khavinshankar merged commit 737ef2d into develop Dec 1, 2023
67 of 69 checks passed
@khavinshankar khavinshankar deleted the fix-6766 branch December 1, 2023 15:55
Copy link

github-actions bot commented Dec 1, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misaligned labels for "Search by number" field in External Results
3 participants