Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HL7 and ventilator middleware override #6778

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Dec 1, 2023

WHAT

🤖[deprecated] Generated by Copilot at c1a1562

This pull request enhances the socket connection for the consultation updates tab by adding a fallback option for the middleware address. It also updates the AssetLocationObject interface to include the middleware_address property.

Proposed Changes

  • Fixes #issue?

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖[deprecated] Generated by Copilot at c1a1562

  • Add middleware_address property to AssetLocationObject interface to store the middleware server address for assets (link)
  • Use middleware_address as a fallback option for constructing HL7 socket URL for monitor bed data, in case middleware_hostname is not available in asset metadata (link)
  • Use middleware_address as a fallback option for constructing ventilator socket URL for ventilator bed data, in case middleware_hostname is not available in asset metadata (link)

update HL7 and ventilator middleware
Copy link

vercel bot commented Dec 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 5:25pm

Copy link

netlify bot commented Dec 1, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c1a1562
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656a16fe9412c50008e44aac
😎 Deploy Preview https://deploy-preview-6778--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

nihal467 commented Dec 1, 2023

LGTM

Copy link

cypress bot commented Dec 1, 2023

Passing run #1658 ↗︎

0 88 0 0 Flakiness 0

Details:

Update HL7 and ventilator middleware override
Project: CARE Commit: c1a1562dd2
Status: Passed Duration: 02:27 💡
Started: Dec 1, 2023 5:33 PM Ended: Dec 1, 2023 5:36 PM

Review all test suite changes for PR #6778 ↗︎

@khavinshankar khavinshankar merged commit b49247c into develop Dec 1, 2023
65 checks passed
@khavinshankar khavinshankar deleted the middleware-fix branch December 1, 2023 17:37
Copy link

github-actions bot commented Dec 1, 2023

@Ashesh3 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants