Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Selected location not being shown for some cases in Assets #6790

Closed

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Dec 4, 2023

component

WHAT

🤖[deprecated] Generated by Copilot at 7b87f12

Refactor LocationSelect component to use useAsyncOptions hook. This enhances the component's efficiency and usability by fetching and caching location options asynchronously.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 7b87f12

  • Import and use useAsyncOptions hook to fetch and cache location options for select component (link, link, link)
  • Remove redundant setLoading state and setter from LocationSelect component (link, link)
  • Update useEffect callback to dispatch listFacilityAssetLocation action and set locations state with data results (link)
  • Modify Select component props to use values and functions from useAsyncOptions hook (link)

Copy link

vercel bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2023 11:55am

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3c17976
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/656f0f6dcc4dd100085df906
😎 Deploy Preview https://deploy-preview-6790--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 13, 2023
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset Update: Selected location not being shown for some cases
1 participant