Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix patient name in transfer success notification #6829

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

konavivekramakrishna
Copy link
Contributor

@konavivekramakrishna konavivekramakrishna commented Dec 8, 2023

WHAT

🤖[deprecated] Generated by Copilot at 0016206

This pull request enhances the user experience and readability of the consultation page URL and the transfer patient dialog. It uses the patient name instead of the id in the URL and shows the patient name when transferring.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 0016206

  • Add a variable patientName to store the patient name from the form state (link)
  • Use patientName instead of patient id in the URL when navigating to the consultation page after transferring the patient (link)

@konavivekramakrishna konavivekramakrishna requested a review from a team as a code owner December 8, 2023 18:29
Copy link

vercel bot commented Dec 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2023 6:58pm

Copy link

netlify bot commented Dec 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 32a0468
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6573672a3a587e0008094b91
😎 Deploy Preview https://deploy-preview-6829--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this works? Your screenshot seems to be different from what you've coded.

image

src/Components/Facility/TransferPatientDialog.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit e292fb7 into coronasafe:develop Dec 13, 2023
29 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient transferred notification shows UUID instead of patient name
4 participants