Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Asset Type" #6835

Closed

Conversation

shyamprakash123
Copy link
Contributor

@shyamprakash123 shyamprakash123 commented Dec 9, 2023

WHAT

🤖[deprecated] Generated by Copilot at be3b8e2

This pull request removes the asset type feature from the frontend components that deal with assets. The asset type is no longer a relevant attribute for filtering, creating, or managing assets, since the backend API only supports internal assets. The affected components are AssetFilter, AssetCreate, and AssetManage.

Proposed Changes

  • Fixes Hide "Asset Type" (Assets to be always "Internal") #6789

  • Removed "Asset Type" select input from asset create/edit form.

  • Upon creating an asset, it is always created with asset type as "Internal" (default)

  • Removed Asset Type label from the asset details page.

  • Removed Asset Type filter from Advanced Filters also.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at be3b8e2

  • Remove the asset type filter option from the AssetFilter component and the filter logic (link, link, link, link)
  • Remove the asset type input option from the AssetCreate component and the asset creation logic (link, link, link, link, link, link)
  • Remove the asset type display from the AssetManage component (link)
  • Hardcode the asset type value to AssetType.INTERNAL for creating or editing the assets in the AssetCreate component (link)

@shyamprakash123 shyamprakash123 requested a review from a team as a code owner December 9, 2023 16:03
Copy link

vercel bot commented Dec 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 3:23pm

Copy link

netlify bot commented Dec 9, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c4b59a4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/65a7f0b1c8b64c0008f2fe5b
😎 Deploy Preview https://deploy-preview-6835--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@shyamprakash123
image

  • modify the cypress test in asset file, when you are hiding the asset type, make necessary change in the file as well

@shyamprakash123
Copy link
Contributor Author

@nihal467

Cypress Tests are now fixed.

Screenshot 2023-12-14 210939
Screenshot 2023-12-14 211001
Screenshot 2023-12-14 211014

@nihal467
Copy link
Member

@shyamprakash123 fix the failing cypress test, you should be fixing cypress with running care in the local frontend and backend by loading dummy data

@shyamprakash123
Copy link
Contributor Author

@nihal467 I reverted the cypress test variables, can you re-test this?

@rithviknishad
Copy link
Member

The cypress test still seems to be failing, could you look into it?

@rithviknishad rithviknishad added the cypress failed pull request with cypress test failure label Dec 25, 2023
@nihal467
Copy link
Member

@shyamprakash123 fix the cypress issue

Copy link

github-actions bot commented Jan 3, 2024

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 3, 2024
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jan 10, 2024
@nihal467 nihal467 reopened this Jan 15, 2024
@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed stale labels Jan 16, 2024
Copy link

👋 Hi, @shyamprakash123,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required cypress failed pull request with cypress test failure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide "Asset Type" (Assets to be always "Internal")
3 participants