Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved the responsiveness issue of Administer medicine Slide-Over #6854

Closed
wants to merge 3 commits into from

Conversation

sagarkori143
Copy link

@sagarkori143 sagarkori143 commented Dec 12, 2023

WHAT

Solved the responsiveness issue of Administer medicine Slide-Over

Proposed Changes

WhatsApp Image 2023-12-03 at 16 34 28_40ae166a

To :

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at dd24fca

  • Adjust the width of the medicine administration component based on the screen size (link)

@sagarkori143 sagarkori143 requested a review from a team as a code owner December 12, 2023 14:53
Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 9:17am

Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7f83596
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/657ac7f587ff880008a7f586
😎 Deploy Preview https://deploy-preview-6854--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@sagarkori143

image

the route field is not properly responsive

@sagarkori143
Copy link
Author

@nihal467 What I'm supposed to do now? Should I decrease the width of administration section to some more extent as the prescription card can't be altered being a reusable component? Please give some clarification about it.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase the width of the slideover a bit more, that should solve it right?

Instead of 1300px, we can go 1400px maybe?

@sagarkori143
Copy link
Author

sagarkori143 commented Dec 14, 2023

@rithviknishad
If I'm operating a device having this much width:

image

You can see that the slide-over is covering whole screen. If I increase the width of slide-over then the user have to slide left and right to see the slide-over content completely. Is it ok doing so?

@rithviknishad
Copy link
Member

Select for administration section can come below the prescriptions detail card whenever there is not enough screen space.

@sagarkori143
Copy link
Author

@nihal467 Is it OK if I do overflow hidden for these boxes content as I have seen the same thing on some other pages too.

image

@sagarkori143
Copy link
Author

@nihal467 A friendly reminder. Please let me know if I can move ahead with this solution and commit the changes.

@rithviknishad
Copy link
Member

I don't think it's okay to hide information (especially in a reusable component where that is the only component that shows the detailed view of the prescription).

Was there any issues in achieving the following?

Select for administration section can come below the prescriptions detail card whenever there is not enough screen space.

Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 28, 2023
Copy link

github-actions bot commented Jan 4, 2024

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jan 4, 2024
@sagarkori143
Copy link
Author

Hey @rithviknishad please reopen this issue. I was in bad health conditions so couldn't give it time again. I am looking forward to work on this and raise a pr again

@rithviknishad rithviknishad reopened this Jan 4, 2024
@github-actions github-actions bot removed the stale label Jan 5, 2024
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 12, 2024
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prescriptions Details Card is not responsive in Bulk Administer Medicines slideover
3 participants