Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Something went wrong" notification when username conflict #6869

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 15, 2023

WHAT

🤖[deprecated] Generated by Copilot at 659dc0d

Fixed a bug that caused the user form to refetch facilities on window focus by adding the silent property to the useQuery hook in UserAdd.tsx.

Proposed Changes

  • Hide "Something went wrong" notification when username conflict

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖[deprecated] Generated by Copilot at 659dc0d

  • Prevent facilities query from refetching on window focus by adding silent property to useQuery hook (link)

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 6:43am

Copy link

netlify bot commented Dec 15, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 659dc0d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/657bf57cc131a50008aa12e3
😎 Deploy Preview https://deploy-preview-6869--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 15, 2023

Passing run #1727 ↗︎

0 91 0 0 Flakiness 0

Details:

Hide "Something went wrong" notification when username conflict
Project: CARE Commit: 659dc0d416
Status: Passed Duration: 02:15 💡
Started: Dec 15, 2023 6:46 AM Ended: Dec 15, 2023 6:49 AM

Review all test suite changes for PR #6869 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b7af525 into develop Dec 15, 2023
43 checks passed
@khavinshankar khavinshankar deleted the hide-user-conflict-notif branch December 15, 2023 06:51
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants