Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for units for max_dosage #6897

Merged
merged 1 commit into from
Dec 23, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Dec 23, 2023

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team as a code owner December 23, 2023 12:02
Copy link

vercel bot commented Dec 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview Dec 23, 2023 0:02am

Copy link

netlify bot commented Dec 23, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6b04fb7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6586cc5e5b01210008cdc69d
😎 Deploy Preview https://deploy-preview-6897--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 23, 2023

Passing run #1750 ↗︎

0 91 0 0 Flakiness 0

Details:

Adds support for units for `max_dosage`
Project: CARE Commit: 6b04fb7edf
Status: Passed Duration: 02:15 💡
Started: Dec 23, 2023 12:06 PM Ended: Dec 23, 2023 12:08 PM

Review all test suite changes for PR #6897 ↗︎

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit d906c6a into develop Dec 23, 2023
31 of 32 checks passed
@khavinshankar khavinshankar deleted the prescriptions/fix-max-dosage-type branch December 23, 2023 12:44
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants