Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OP number to treatment summary. #6898

Merged
merged 8 commits into from
Dec 28, 2023
Merged

Add OP number to treatment summary. #6898

merged 8 commits into from
Dec 28, 2023

Conversation

AshrafMd-1
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@AshrafMd-1 AshrafMd-1 requested a review from a team as a code owner December 23, 2023 14:44
@vercel Vercel
Copy link

vercel bot commented Dec 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 28, 2023 11:03am

@netlify Netlify
Copy link

netlify bot commented Dec 23, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 272e48c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/658d55c3bc592a00082caf6b
😎 Deploy Preview https://deploy-preview-6898--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nihal467
Copy link
Member

@AshrafMd-1

image

  • above is the staging print preview of the current staging

image

  • above is the current PR deployment print preview

make the below changes in the PR:

  • make the print preview proper width proportion, in your deploy preview, the left side and right side width usage in print preview is not uniform
    image

  • add the IP no column next to the age

@nihal467
Copy link
Member

@AshrafMd-1 can you push the fix before Tomorrow EOD, we need to close it this week

@nihal467 nihal467 added the P2 label Dec 27, 2023
@AshrafMd-1
Copy link
Contributor Author

@nihal467 once can u check.

@AshrafMd-1
Copy link
Contributor Author

@rithviknishad can u change the label

@nihal467
Copy link
Member

@AshrafMd-1
image

the bug still exist, the borders are not uniform, keep it as it is in current staging

@AshrafMd-1
Copy link
Contributor Author

@nihal467 I tried multiple ways and this is the only way it worked by adding an extra column
image
Already pushed the update
can u check if its okay .

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 4a49768 into coronasafe:develop Dec 28, 2023
35 of 36 checks passed
@github-actions GitHub Actions
Copy link

@AshrafMd-1 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@AshrafMd-1 AshrafMd-1 deleted the Fix-6885 branch December 28, 2023 12:47
Ashesh3 pushed a commit that referenced this pull request Jan 2, 2024
@AshrafMd-1 @Ashesh3
Add OP number to treatment summary. (#6898)
bd605b5 
* add op

* Add correct borders in treatment summary

* Update TreatmentSummary.tsx

* add space

* add extra cols
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

Assignees
No one assigned
Labels
P2 tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add IP Number in Treatment Summary
4 participants
@AshrafMd-1 @nihal467 @khavinshankar @rithviknishad